Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config #226

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Improve config #226

merged 5 commits into from
Jul 12, 2023

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️/❌
Breaks BC? ❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@rustamwin rustamwin requested a review from a team April 20, 2023 06:58
@rustamwin rustamwin added the status:code review The pull request needs review. label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4d0ab5d) 99.74% compared to head (86661a7) 99.74%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage     99.74%   99.74%           
  Complexity      299      299           
=========================================
  Files            18       18           
  Lines           791      791           
=========================================
  Hits            789      789           
  Misses            2        2
Impacted Files Coverage Δ
src/ViewTrait.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rustamwin rustamwin mentioned this pull request Apr 20, 2023
Open
samdark
samdark reviewed Apr 20, 2023
View reviewed changes
src/ViewInterface.php Outdated Show resolved Hide resolved
@vjik
Copy link
Member

vjik commented Apr 20, 2023

See yiisoft/view-twig#61 (review)

vjik
vjik reviewed Jun 6, 2023
View reviewed changes
src/TemplateRendererInterface.php Outdated Show resolved Hide resolved
src/Template.php Outdated Show resolved Hide resolved
@rustamwin rustamwin changed the title Improve config, ability to get view context Improve config, add Template class Jun 6, 2023
@rustamwin rustamwin requested a review from a team June 24, 2023 06:17
@samdark
Copy link
Member

samdark commented Jul 11, 2023

@rustamwin let's split Add class Template that holds the information for rendering part into separate pull request since it's what is questionable. The rest are definitely changes to be applied.

@rustamwin rustamwin changed the title Improve config, add Template class Improve config Jul 11, 2023
@rustamwin
Copy link
Member Author

Done.

@rustamwin rustamwin requested review from samdark and vjik July 12, 2023 06:29
vjik
vjik approved these changes Jul 12, 2023
View reviewed changes
config/di.php Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
config/di-web.php Outdated Show resolved Hide resolved
@rustamwin @vjik
Apply suggestions from code review
86661a7 
Co-authored-by: Sergei Predvoditelev <[email protected]>
@samdark samdark merged commit 6703eba into master Jul 12, 2023
25 of 27 checks passed
@samdark samdark deleted the improve branch July 12, 2023 15:14
@samdark
Copy link
Member

samdark commented Jul 12, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustamwin @vjik @samdark